vibecoded audio fix?
This commit is contained in:
parent
53b8655dd6
commit
fca971e13c
2 changed files with 87 additions and 21 deletions
|
@ -27,19 +27,16 @@ export default defineComponent({
|
||||||
console.debug(`[AUDIOAREA] Initializing ${props.definition.src}...`);
|
console.debug(`[AUDIOAREA] Initializing ${props.definition.src}...`);
|
||||||
console.debug(props.definition);
|
console.debug(props.definition);
|
||||||
|
|
||||||
// Silent 1ms audio as placeholder (data URI of a minimal silent MP3)
|
|
||||||
// This prevents browser from attempting to load any audio until we're ready
|
|
||||||
const SILENT_AUDIO = 'data:audio/mp3;base64,SUQzAwAAAAAAJlRJVDIAAAAHAAAAU2lsZW50/+MYxAAEaAIAAgAAAAkBngQAAABMQVJHAAAABQAA/+MYxA8EaAIAAgAAABAAAP/7kMQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD/4xjEMgAAAAACAAAAAAAAAP/jGMRFAAAAAAAAAAAAAAAAAAAA';
|
|
||||||
|
|
||||||
// Preload the audio file completely to avoid keeping connections open
|
// Preload the audio file completely to avoid keeping connections open
|
||||||
// Use the global audio loading queue to throttle concurrent loads
|
// Use the global audio loading queue to throttle concurrent loads
|
||||||
const preloadAudio = (src: string) => {
|
const preloadAudio = (src: string) => {
|
||||||
console.debug(`[AUDIOAREA] Queueing audio for preload: ${src}`);
|
console.debug(`[AUDIOAREA] Queueing audio for preload: ${src}`);
|
||||||
|
|
||||||
// Set placeholder silent audio to avoid errors without triggering real load
|
// Set audioSrc to empty initially
|
||||||
audioSrc.value = SILENT_AUDIO;
|
audioSrc.value = "";
|
||||||
|
|
||||||
// Queue the audio for loading through our global service
|
// Queue the audio for loading through our global service
|
||||||
|
// Our improved AudioLoader will cache and deduplicate requests
|
||||||
queueAudioForLoading(src)
|
queueAudioForLoading(src)
|
||||||
.then((blobUrl) => {
|
.then((blobUrl) => {
|
||||||
// Use blob URL to avoid keeping connections open
|
// Use blob URL to avoid keeping connections open
|
||||||
|
|
|
@ -13,6 +13,12 @@ const audioQueue: Array<{
|
||||||
onError: (error: Error) => void;
|
onError: (error: Error) => void;
|
||||||
}> = [];
|
}> = [];
|
||||||
|
|
||||||
|
// Cache of loaded audio files (src -> blobUrl)
|
||||||
|
const loadedAudioCache: Record<string, string> = {};
|
||||||
|
|
||||||
|
// Keep track of pending loads to avoid duplicates
|
||||||
|
const pendingLoads: Set<string> = new Set();
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Queue an audio file for loading, respecting the global concurrent loading limit
|
* Queue an audio file for loading, respecting the global concurrent loading limit
|
||||||
* Returns a promise that resolves with the blob URL when loading is complete
|
* Returns a promise that resolves with the blob URL when loading is complete
|
||||||
|
@ -22,6 +28,35 @@ export function queueAudioForLoading(
|
||||||
onComplete?: (blobUrl: string) => void,
|
onComplete?: (blobUrl: string) => void,
|
||||||
onError?: (error: Error) => void
|
onError?: (error: Error) => void
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
|
// Return cached result immediately if available
|
||||||
|
if (loadedAudioCache[src]) {
|
||||||
|
console.debug(`[AudioLoader] Using cached audio for ${src}`);
|
||||||
|
const blobUrl = loadedAudioCache[src];
|
||||||
|
if (onComplete) setTimeout(() => onComplete(blobUrl), 0);
|
||||||
|
return Promise.resolve(blobUrl);
|
||||||
|
}
|
||||||
|
|
||||||
|
// If this source is already being loaded, add to existing promises
|
||||||
|
if (pendingLoads.has(src)) {
|
||||||
|
console.debug(`[AudioLoader] Already loading ${src}, adding to pending requests`);
|
||||||
|
return new Promise((resolve, reject) => {
|
||||||
|
audioQueue.push({
|
||||||
|
src,
|
||||||
|
onComplete: (blobUrl) => {
|
||||||
|
if (onComplete) onComplete(blobUrl);
|
||||||
|
resolve(blobUrl);
|
||||||
|
},
|
||||||
|
onError: (error) => {
|
||||||
|
if (onError) onError(error);
|
||||||
|
reject(error);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
// Mark as pending
|
||||||
|
pendingLoads.add(src);
|
||||||
|
|
||||||
return new Promise((resolve, reject) => {
|
return new Promise((resolve, reject) => {
|
||||||
// Add to queue
|
// Add to queue
|
||||||
audioQueue.push({
|
audioQueue.push({
|
||||||
|
@ -45,28 +80,56 @@ export function queueAudioForLoading(
|
||||||
* Process the next items in the queue if we have capacity
|
* Process the next items in the queue if we have capacity
|
||||||
*/
|
*/
|
||||||
function processQueue() {
|
function processQueue() {
|
||||||
// Load more audio files if we have capacity and items in the queue
|
// Group queue items by src to avoid duplicate loads
|
||||||
|
const nextBatch: Record<string, Array<{
|
||||||
|
onComplete: (blobUrl: string) => void;
|
||||||
|
onError: (error: Error) => void;
|
||||||
|
}>> = {};
|
||||||
|
|
||||||
|
// Find next items to process while respecting MAX_CONCURRENT_LOADS
|
||||||
while (activeLoads < MAX_CONCURRENT_LOADS && audioQueue.length > 0) {
|
while (activeLoads < MAX_CONCURRENT_LOADS && audioQueue.length > 0) {
|
||||||
const next = audioQueue.shift();
|
const next = audioQueue.shift();
|
||||||
if (next) {
|
if (!next) continue;
|
||||||
loadAudio(next.src, next.onComplete, next.onError);
|
|
||||||
|
// If already cached, complete immediately without consuming a slot
|
||||||
|
if (loadedAudioCache[next.src]) {
|
||||||
|
next.onComplete(loadedAudioCache[next.src]);
|
||||||
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Group by src
|
||||||
|
if (!nextBatch[next.src]) {
|
||||||
|
nextBatch[next.src] = [];
|
||||||
|
// Each unique src counts as one active load
|
||||||
|
activeLoads++;
|
||||||
|
}
|
||||||
|
|
||||||
|
nextBatch[next.src].push({
|
||||||
|
onComplete: next.onComplete,
|
||||||
|
onError: next.onError
|
||||||
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Start loading each unique audio file
|
||||||
|
Object.entries(nextBatch).forEach(([src, handlers]) => {
|
||||||
|
loadAudio(src, handlers);
|
||||||
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Internal function to handle the actual audio loading using fetch API
|
* Internal function to handle the actual audio loading using fetch API
|
||||||
* This ensures the entire audio file is downloaded
|
* This ensures the entire audio file is downloaded
|
||||||
|
* @param src The source URL to load
|
||||||
|
* @param handlers Array of handlers to call when loading completes or fails
|
||||||
*/
|
*/
|
||||||
async function loadAudio(
|
async function loadAudio(
|
||||||
src: string,
|
src: string,
|
||||||
onComplete: (blobUrl: string) => void,
|
handlers: Array<{
|
||||||
onError: (error: Error) => void
|
onComplete: (blobUrl: string) => void;
|
||||||
|
onError: (error: Error) => void;
|
||||||
|
}>
|
||||||
) {
|
) {
|
||||||
// Increment active loads counter
|
console.debug(`[AudioLoader] Loading ${src} (${handlers.length} listeners)`);
|
||||||
activeLoads++;
|
|
||||||
|
|
||||||
console.debug(`[AudioLoader] Loading ${src}`);
|
|
||||||
|
|
||||||
try {
|
try {
|
||||||
// Fetch the entire audio file
|
// Fetch the entire audio file
|
||||||
|
@ -82,16 +145,22 @@ async function loadAudio(
|
||||||
// Create a blob URL to use as the audio source
|
// Create a blob URL to use as the audio source
|
||||||
const blobUrl = URL.createObjectURL(blob);
|
const blobUrl = URL.createObjectURL(blob);
|
||||||
|
|
||||||
|
// Store in cache
|
||||||
|
loadedAudioCache[src] = blobUrl;
|
||||||
|
|
||||||
console.debug(`[AudioLoader] Successfully loaded ${src}`);
|
console.debug(`[AudioLoader] Successfully loaded ${src}`);
|
||||||
|
|
||||||
// Call completion handler
|
// Call all completion handlers
|
||||||
onComplete(blobUrl);
|
handlers.forEach(handler => handler.onComplete(blobUrl));
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
console.error(`[AudioLoader] Error loading audio: ${error}`);
|
console.error(`[AudioLoader] Error loading audio: ${error}`);
|
||||||
|
|
||||||
// Call error handler
|
// Call all error handlers
|
||||||
onError(error as Error);
|
handlers.forEach(handler => handler.onError(error as Error));
|
||||||
} finally {
|
} finally {
|
||||||
|
// Remove from pending loads
|
||||||
|
pendingLoads.delete(src);
|
||||||
|
|
||||||
// Decrement counter when audio is loaded (or failed)
|
// Decrement counter when audio is loaded (or failed)
|
||||||
activeLoads--;
|
activeLoads--;
|
||||||
|
|
||||||
|
|
Loading…
Add table
Reference in a new issue